Correctly update the video orientation after the permission prompt appeared#166
Open
ralfebert wants to merge 1 commit intotwostraws:mainfrom
Open
Correctly update the video orientation after the permission prompt appeared#166ralfebert wants to merge 1 commit intotwostraws:mainfrom
ralfebert wants to merge 1 commit intotwostraws:mainfrom
Conversation
Contributor
ralfebert
commented
Mar 12, 2025
ralfebert
commented
- When the permission prompt appears, updateOrientation was called before the AV connection was established and the orientation was not updated afterwards when the connection is available
- Update previewLayer.connection instead of captureSession?.connections.last
- Remove implicit forced unwrap for previewLayer property
…peared - When the permission prompt appears, updateOrientation was called before the AV connection was established and not updated afterwards - Update previewLayer.connection instead of captureSession?.connections.last - Remove implicit forced unwrap for previewLayer property
|
@ralfebert what does the user see before this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.